diff options
| author | Stan Hu <stanhu@gmail.com> | 2016-10-25 01:37:16 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2016-10-25 06:52:44 -0700 |
| commit | ed47f4a30891529eac2fcc99a344038bf3793cc4 (patch) | |
| tree | ad0d3c76691cead4043adc2aabdae567667bc8a7 /app/finders | |
| parent | add3a2c4431f29ca84c956f5604769505f0f0904 (diff) | |
| download | gitlab-ce-ed47f4a30891529eac2fcc99a344038bf3793cc4.tar.gz | |
Reduce overhead of LabelFinder by avoiding #presence callsh-optimize-label-finder
Some users experienced 502 timeouts when viewing group labels.
Labels#open_issues_count and Label#open_merge_requests_count were
taking a long time to load because they were loading every ActiveRecord
of the user-accessible projects into memory. This change modifies the system
so that #presence and hence to_a isn't called.
Closes #23684
Diffstat (limited to 'app/finders')
| -rw-r--r-- | app/finders/labels_finder.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/finders/labels_finder.rb b/app/finders/labels_finder.rb index 6ace14a4bb5..44c659b609a 100644 --- a/app/finders/labels_finder.rb +++ b/app/finders/labels_finder.rb @@ -48,7 +48,7 @@ class LabelsFinder < UnionFinder end def projects_ids - params[:project_ids].presence + params[:project_ids] end def title |