summaryrefslogtreecommitdiff
path: root/app/helpers/diff_helper.rb
diff options
context:
space:
mode:
authorDouwe Maan <douwe@selenight.nl>2017-06-19 11:25:21 -0500
committerDouwe Maan <douwe@selenight.nl>2017-06-19 11:50:46 -0500
commit5e8aca215243d2eaacb0a1b744909af2b7264a32 (patch)
treede0f75c16f746c62fbe19a74514f1f9fe7beb64c /app/helpers/diff_helper.rb
parentc0c394262833a4a35e3b2f7006ba6a4e93ef80d1 (diff)
downloadgitlab-ce-5e8aca215243d2eaacb0a1b744909af2b7264a32.tar.gz
Don't display comment on unchanged line on both sides in parallel diff
Diffstat (limited to 'app/helpers/diff_helper.rb')
-rw-r--r--app/helpers/diff_helper.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/app/helpers/diff_helper.rb b/app/helpers/diff_helper.rb
index 06822747d11..16a99addd0b 100644
--- a/app/helpers/diff_helper.rb
+++ b/app/helpers/diff_helper.rb
@@ -66,12 +66,12 @@ module DiffHelper
discussions_left = discussions_right = nil
- if left && (left.unchanged? || left.discussable?)
+ if left && left.discussable? && (left.unchanged? || left.removed?)
line_code = diff_file.line_code(left)
discussions_left = @grouped_diff_discussions[line_code]
end
- if right&.discussable?
+ if right && right.discussable? && right.added?
line_code = diff_file.line_code(right)
discussions_right = @grouped_diff_discussions[line_code]
end