diff options
| author | Robert Speicher <rspeicher@gmail.com> | 2017-08-10 12:39:26 -0400 |
|---|---|---|
| committer | Robert Speicher <rspeicher@gmail.com> | 2017-08-14 12:14:11 -0400 |
| commit | 260c8da060a6039cbd47cfe31c8ec6d6f9b43de0 (patch) | |
| tree | bd6dd444c6f416c7209d88bf80e0e9322037758d /app/helpers/milestones_helper.rb | |
| parent | a64760d6d0a9bc0ce0747de349d37f3c46a1c221 (diff) | |
| download | gitlab-ce-260c8da060a6039cbd47cfe31c8ec6d6f9b43de0.tar.gz | |
Whitelist or fix additional `Gitlab/PublicSend` cop violationsrs-more-public-send-whitelists
An upcoming update to rubocop-gitlab-security added additional
violations.
Diffstat (limited to 'app/helpers/milestones_helper.rb')
| -rw-r--r-- | app/helpers/milestones_helper.rb | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/app/helpers/milestones_helper.rb b/app/helpers/milestones_helper.rb index f8860bfee99..86666022a2a 100644 --- a/app/helpers/milestones_helper.rb +++ b/app/helpers/milestones_helper.rb @@ -32,7 +32,18 @@ module MilestonesHelper end def milestone_issues_by_label_count(milestone, label, state:) - milestone.issues.with_label(label.title).send(state).size + issues = milestone.issues.with_label(label.title) + issues = + case state + when :opened + issues.opened + when :closed + issues.closed + else + raise ArgumentError, "invalid milestone state `#{state}`" + end + + issues.size end # Returns count of milestones for different states |