diff options
| author | Ciro Santilli <ciro.santilli@gmail.com> | 2014-09-19 15:26:20 +0200 |
|---|---|---|
| committer | Ciro Santilli <ciro.santilli@gmail.com> | 2014-09-22 21:01:19 +0200 |
| commit | 778afb699f08d6b8e7f1ac5e77e927f45e11f8be (patch) | |
| tree | 24ffbfb9b166d5358fe44e252b6f4e4084d97be5 /app/helpers/notes_helper.rb | |
| parent | 248990b5e8e169d7c48adb539980a9db6cea4eca (diff) | |
| download | gitlab-ce-778afb699f08d6b8e7f1ac5e77e927f45e11f8be.tar.gz | |
Replace javascript:; links with buttons.
Diffstat (limited to 'app/helpers/notes_helper.rb')
| -rw-r--r-- | app/helpers/notes_helper.rb | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/app/helpers/notes_helper.rb b/app/helpers/notes_helper.rb index cddcae464b0..15d4b875c4c 100644 --- a/app/helpers/notes_helper.rb +++ b/app/helpers/notes_helper.rb @@ -52,8 +52,8 @@ module NotesHelper discussion_id: discussion_id } - link_to "", "javascript:;", class: "add-diff-note js-add-diff-note-button", - data: data, title: "Add a comment to this line" + button_tag '', class: 'btn add-diff-note js-add-diff-note-button', + data: data, title: 'Add a comment to this line' end def link_to_reply_diff(note) @@ -67,8 +67,8 @@ module NotesHelper discussion_id: note.discussion_id } - link_to "javascript:;", class: "btn reply-btn js-discussion-reply-button", - data: data, title: "Add a reply" do + button_tag class: 'btn reply-btn js-discussion-reply-button', + data: data, title: 'Add a reply' do link_text = content_tag(:i, nil, class: 'icon-comment') link_text << ' Reply' end |