summaryrefslogtreecommitdiff
path: root/app/helpers
diff options
context:
space:
mode:
authorScott Hampton <shampton@gitlab.com>2019-08-23 21:28:46 +0000
committerMayra Cabrera <mcabrera@gitlab.com>2019-08-23 21:28:46 +0000
commitf093ceb4a0b15420cfe64fa9d97e73531b5fb35c (patch)
tree06df7eaa8b947b6fb9a06eb25d5e7be82e351287 /app/helpers
parent1d462d23a94e6ee8a0151444a01ea5858350886b (diff)
downloadgitlab-ce-f093ceb4a0b15420cfe64fa9d97e73531b5fb35c.tar.gz
Change misleading pipeline status tooltip
Some pipeline status icon tooltips were showing "Commit: ..." which customers found to be misleading since it was not the commit that was failing but the pipeline. We are changing all status icon tooltips to say "Pipeline: ..." instead of "Commit: ..." now.
Diffstat (limited to 'app/helpers')
-rw-r--r--app/helpers/ci_status_helper.rb3
1 files changed, 1 insertions, 2 deletions
diff --git a/app/helpers/ci_status_helper.rb b/app/helpers/ci_status_helper.rb
index f2b5b82b013..144df676304 100644
--- a/app/helpers/ci_status_helper.rb
+++ b/app/helpers/ci_status_helper.rb
@@ -105,14 +105,13 @@ module CiStatusHelper
path = pipelines_project_commit_path(project, commit, ref: ref)
render_status_with_link(
- 'commit',
commit.status(ref),
path,
tooltip_placement: tooltip_placement,
icon_size: 24)
end
- def render_status_with_link(type, status, path = nil, tooltip_placement: 'left', cssclass: '', container: 'body', icon_size: 16)
+ def render_status_with_link(status, path = nil, type: _('pipeline'), tooltip_placement: 'left', cssclass: '', container: 'body', icon_size: 16)
klass = "ci-status-link ci-status-icon-#{status.dasherize} d-inline-flex #{cssclass}"
title = "#{type.titleize}: #{ci_label_for_status(status)}"
data = { toggle: 'tooltip', placement: tooltip_placement, container: container }