summaryrefslogtreecommitdiff
path: root/app/helpers
diff options
context:
space:
mode:
authorCiro Santilli <ciro.santilli@gmail.com>2014-09-26 00:07:40 +0200
committerCiro Santilli <ciro.santilli@gmail.com>2014-10-03 09:18:46 +0200
commit2e9f5de86896e53e9cf34aef52bbc2ad08019a21 (patch)
tree48c469b4e8a9f4596f978a2602e4d3b5cfbece86 /app/helpers
parenta3d90c5045ae322a013484165cdebcd764dc5d69 (diff)
downloadgitlab-ce-2e9f5de86896e53e9cf34aef52bbc2ad08019a21.tar.gz
Add parenthesis to function def with arguments.
Diffstat (limited to 'app/helpers')
-rw-r--r--app/helpers/events_helper.rb2
-rw-r--r--app/helpers/issues_helper.rb4
-rw-r--r--app/helpers/merge_requests_helper.rb4
-rw-r--r--app/helpers/profile_helper.rb2
-rw-r--r--app/helpers/projects_helper.rb4
-rw-r--r--app/helpers/tab_helper.rb2
-rw-r--r--app/helpers/tags_helper.rb4
-rw-r--r--app/helpers/tree_helper.rb2
8 files changed, 12 insertions, 12 deletions
diff --git a/app/helpers/events_helper.rb b/app/helpers/events_helper.rb
index 6f738764b0e..10a895d8cae 100644
--- a/app/helpers/events_helper.rb
+++ b/app/helpers/events_helper.rb
@@ -19,7 +19,7 @@ module EventsHelper
[event.action_name, target].join(" ")
end
- def event_filter_link key, tooltip
+ def event_filter_link(key, tooltip)
key = key.to_s
inactive = if @event_filter.active? key
nil
diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb
index 2031519c32f..7671033b539 100644
--- a/app/helpers/issues_helper.rb
+++ b/app/helpers/issues_helper.rb
@@ -1,5 +1,5 @@
module IssuesHelper
- def issue_css_classes issue
+ def issue_css_classes(issue)
classes = "issue"
classes << " closed" if issue.closed?
classes << " today" if issue.today?
@@ -84,7 +84,7 @@ module IssuesHelper
'id', 'name', object.assignee_id)
end
- def milestone_options object
+ def milestone_options(object)
options_from_collection_for_select(object.project.milestones.active,
'id', 'title', object.milestone_id)
end
diff --git a/app/helpers/merge_requests_helper.rb b/app/helpers/merge_requests_helper.rb
index cc63db2035e..d1ea47eb7b3 100644
--- a/app/helpers/merge_requests_helper.rb
+++ b/app/helpers/merge_requests_helper.rb
@@ -24,14 +24,14 @@ module MergeRequestsHelper
}
end
- def mr_css_classes mr
+ def mr_css_classes(mr)
classes = "merge-request"
classes << " closed" if mr.closed?
classes << " merged" if mr.merged?
classes
end
- def ci_build_details_path merge_request
+ def ci_build_details_path(merge_request)
merge_request.source_project.ci_service.build_page(merge_request.last_commit.sha)
end
diff --git a/app/helpers/profile_helper.rb b/app/helpers/profile_helper.rb
index 297ae83d895..0b375558305 100644
--- a/app/helpers/profile_helper.rb
+++ b/app/helpers/profile_helper.rb
@@ -1,5 +1,5 @@
module ProfileHelper
- def oauth_active_class provider
+ def oauth_active_class(provider)
if current_user.provider == provider.to_s
'active'
end
diff --git a/app/helpers/projects_helper.rb b/app/helpers/projects_helper.rb
index f7da30bcc4b..6a16f112cb3 100644
--- a/app/helpers/projects_helper.rb
+++ b/app/helpers/projects_helper.rb
@@ -3,7 +3,7 @@ module ProjectsHelper
"You are going to remove #{user.name} from #{project.name} project team. Are you sure?"
end
- def link_to_project project
+ def link_to_project(project)
link_to project do
title = content_tag(:span, project.name, class: 'project-name')
@@ -39,7 +39,7 @@ module ProjectsHelper
end
end
- def project_title project
+ def project_title(project)
if project.group
content_tag :span do
link_to(simple_sanitize(project.group.name), group_path(project.group)) + " / " + project.name
diff --git a/app/helpers/tab_helper.rb b/app/helpers/tab_helper.rb
index 610175f8447..bc43e078568 100644
--- a/app/helpers/tab_helper.rb
+++ b/app/helpers/tab_helper.rb
@@ -89,7 +89,7 @@ module TabHelper
end
# Use nav_tab for save controller/action but different params
- def nav_tab key, value, &block
+ def nav_tab(key, value, &block)
o = {}
o[:class] = ""
diff --git a/app/helpers/tags_helper.rb b/app/helpers/tags_helper.rb
index ebed6a83746..ef89bb32c6d 100644
--- a/app/helpers/tags_helper.rb
+++ b/app/helpers/tags_helper.rb
@@ -1,9 +1,9 @@
module TagsHelper
- def tag_path tag
+ def tag_path(tag)
"/tags/#{tag}"
end
- def tag_list project
+ def tag_list(project)
html = ''
project.tag_list.each do |tag|
html += link_to tag, tag_path(tag)
diff --git a/app/helpers/tree_helper.rb b/app/helpers/tree_helper.rb
index d815257a4e3..ed3c401d873 100644
--- a/app/helpers/tree_helper.rb
+++ b/app/helpers/tree_helper.rb
@@ -80,7 +80,7 @@ module TreeHelper
end
end
- def up_dir_path tree
+ def up_dir_path(tree)
file = File.join(@path, "..")
tree_join(@ref, file)
end