Fix tests for Snippets toggling awards

Also incorporate feedback

2 files changed, 11 insertions, 7 deletions

diff --git a/app/helpers/award_emoji_helper.rb b/app/helpers/award_emoji_helper.rb
index c358abc52ea..aa134cea31c 100644
--- a/app/helpers/award_emoji_helper.rb
+++ b/app/helpers/award_emoji_helper.rb
@@ -1,13 +1,9 @@
 module AwardEmojiHelper
   def toggle_award_url(awardable)
-    unless awardable.is_a?(Snippet)
-      return url_for([:toggle_award_emoji, @project.namespace.becomes(Namespace), @project, awardable])
-    end
-
-    if awardable.is_a?(ProjectSnippet)
-      toggle_award_emoji_namespace_project_snippet_path(@project.namespace.becomes(Namespace), @project, awardable)
+    if @project
+      url_for([:toggle_award_emoji, @project.namespace.becomes(Namespace), @project, awardable])
     else
-      toggle_award_emoji_snippet_url(awardable)
+      url_for([:toggle_award_emoji, awardable])
     end
   end
 end
diff --git a/app/helpers/gitlab_routing_helper.rb b/app/helpers/gitlab_routing_helper.rb
index a322a90cc4e..6277c138479 100644
--- a/app/helpers/gitlab_routing_helper.rb
+++ b/app/helpers/gitlab_routing_helper.rb
@@ -98,6 +98,14 @@ module GitlabRoutingHelper
     end
   end
 
+  def toggle_award_emoji_personal_snippet_path(*args)
+    toggle_award_emoji_snippet_path(*args)
+  end
+
+  def toggle_award_emoji_namespace_project_project_snippet_path(*args)
+    toggle_award_emoji_namespace_project_snippet_path(*args)
+  end
+
   ## Members
   def project_members_url(project, *args)
     namespace_project_project_members_url(project.namespace, project)