diff options
author | Bryce Johnson <bryce@gitlab.com> | 2017-06-12 14:43:21 -0400 |
---|---|---|
committer | Bryce Johnson <bryce@gitlab.com> | 2017-06-29 12:50:45 -0400 |
commit | 81e9c2842574b10d694a8e29665c77fde7fd6ae5 (patch) | |
tree | c7fad475df58553505885b9e2de9b9543bc6d3f3 /app/helpers | |
parent | 066a6c8ba8900f0883ee788d901d300850b1ae61 (diff) | |
download | gitlab-ce-81e9c2842574b10d694a8e29665c77fde7fd6ae5.tar.gz |
Render add-diff-note button with server.
This commit moves the rendering of the button back to the server, and
shows/hides it using opacity rather than display. It also removes the
transform applied to the button on hover (scale). Previously, both of these
factors automatically triggered a reflow, which creates a performance
bottleneck on pages with larger DOM size.
MR: !12103
Diffstat (limited to 'app/helpers')
-rw-r--r-- | app/helpers/notes_helper.rb | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/app/helpers/notes_helper.rb b/app/helpers/notes_helper.rb index 64ad7b280cb..ecc6cd6c6c5 100644 --- a/app/helpers/notes_helper.rb +++ b/app/helpers/notes_helper.rb @@ -47,6 +47,18 @@ module NotesHelper data end + def add_diff_note_button(line_code, position, line_type) + return if @diff_notes_disabled + + button_tag '', + class: 'add-diff-note js-add-diff-note-button', + type: 'submit', name: 'button', + data: diff_view_line_data(line_code, position, line_type), + title: 'Add a comment to this line' do + icon('comment-o') + end + end + def link_to_reply_discussion(discussion, line_type = nil) return unless current_user |