summaryrefslogtreecommitdiff
path: root/app/models/ci/build.rb
diff options
context:
space:
mode:
authorLeandro Camargo <leandroico@gmail.com>2016-12-09 00:20:39 -0200
committerLeandro Camargo <leandroico@gmail.com>2017-01-25 01:07:44 -0200
commit518fd2eb93711e1e9c3d597a6bdf13366d9abdb5 (patch)
treebaa842d486f475c1805423c142bbbcb830f1fe77 /app/models/ci/build.rb
parentbe7106a145b1e3d4c6e06503e0f7f3032ace3764 (diff)
downloadgitlab-ce-518fd2eb93711e1e9c3d597a6bdf13366d9abdb5.tar.gz
Improve/polish code logic for some Ci::Build methods
Diffstat (limited to 'app/models/ci/build.rb')
-rw-r--r--app/models/ci/build.rb8
1 files changed, 4 insertions, 4 deletions
diff --git a/app/models/ci/build.rb b/app/models/ci/build.rb
index e3753869b67..2a613d12913 100644
--- a/app/models/ci/build.rb
+++ b/app/models/ci/build.rb
@@ -275,11 +275,11 @@ module Ci
end
def update_coverage
- regex = coverage_regex.to_s[1...-1]
+ regex = coverage_regex
- return if regex.blank?
+ return unless regex
- coverage = extract_coverage(trace, regex)
+ coverage = extract_coverage(trace, regex[1...-1])
if coverage.is_a? Numeric
update_attributes(coverage: coverage)
@@ -526,7 +526,7 @@ module Ci
def coverage_regex
super ||
project.try(:build_coverage_regex).presence &&
- "/#{project.try(:build_coverage_regex)}/"
+ "/#{project.build_coverage_regex}/"
end
def when