Add validation and skip logic at #truncate

1 files changed, 5 insertions, 2 deletions

diff --git a/app/models/ci/build_trace_chunk.rb b/app/models/ci/build_trace_chunk.rb
index 870b4ae2033..08a4465821c 100644
--- a/app/models/ci/build_trace_chunk.rb
+++ b/app/models/ci/build_trace_chunk.rb
@@ -28,11 +28,14 @@ module Ci
     end
 
     def truncate(offset = 0)
-      self.append("", offset) if offset < size
+      raise ArgumentError, 'Offset is out of range' if offset > size || offset < 0
+      return if offset == size # Skip the following process as it doesn't affect anything
+
+      self.append("", offset)
     end
 
     def append(new_data, offset)
-      raise ArgumentError, 'Offset is out of range' if offset > data.bytesize || offset < 0
+      raise ArgumentError, 'Offset is out of range' if offset > size || offset < 0
       raise ArgumentError, 'Chunk size overflow' if CHUNK_SIZE < (offset + new_data.bytesize)
 
       set_data(data.byteslice(0, offset) + new_data)