summaryrefslogtreecommitdiff
path: root/app/models/ci/pipeline.rb
diff options
context:
space:
mode:
authorGrzegorz Bizon <grzesiek.bizon@gmail.com>2016-06-15 14:03:43 +0200
committerGrzegorz Bizon <grzesiek.bizon@gmail.com>2016-06-15 14:12:25 +0200
commit2d495fce529cc3ac15f7096ddf9962db0fbd1e23 (patch)
tree66898d776423e166e2bc9ef1a287653e7c704d84 /app/models/ci/pipeline.rb
parent69112072ca915e8d051f39bb8642f1c4fee4b692 (diff)
downloadgitlab-ce-2d495fce529cc3ac15f7096ddf9962db0fbd1e23.tar.gz
Remove reduntant method for building pipeline builds
Diffstat (limited to 'app/models/ci/pipeline.rb')
-rw-r--r--app/models/ci/pipeline.rb12
1 files changed, 5 insertions, 7 deletions
diff --git a/app/models/ci/pipeline.rb b/app/models/ci/pipeline.rb
index 58c69251824..a26cb7dd7ee 100644
--- a/app/models/ci/pipeline.rb
+++ b/app/models/ci/pipeline.rb
@@ -91,15 +91,14 @@ module Ci
trigger_requests.any?
end
- def build_builds(user, trigger_request = nil)
+ def create_builds(user, trigger_request = nil)
+ ##
+ # We persist pipeline only if there are builds available
+ #
return unless config_processor
build_builds_for_stages(config_processor.stages, user,
- 'success', trigger_request)
- end
-
- def create_builds(user, trigger_request = nil)
- build_builds(user, trigger_request) && save
+ 'success', trigger_request) && save
end
def create_next_builds(build)
@@ -121,7 +120,6 @@ module Ci
# and save pipeline if we have builds
build_builds_for_stages(next_stages, build.user, prior_status,
build.trigger_request) && save
-
end
def retried