diff options
| author | Rémy Coutable <remy@rymai.me> | 2016-10-24 10:58:03 +0000 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2016-10-24 10:58:03 +0000 |
| commit | 5bd4bee00fd1c5bd0bbccd330bf10fd9edc5e742 (patch) | |
| tree | fb1acc7062e342d075fb9888d787202f15d9e878 /app/models/commit.rb | |
| parent | ed256037427f1a9b92fabe430e392e600720a29f (diff) | |
| parent | b1ce2eb1e5f6a4a5b413381489fbb7e63ff3e1e5 (diff) | |
| download | gitlab-ce-5bd4bee00fd1c5bd0bbccd330bf10fd9edc5e742.tar.gz | |
Merge branch 'remove-callback' into 'master'
This MR removes AR before_validation callback in favor setter.
## Why was this MR needed?
Because setters is good practice to normalize model attributes instead AR callbacks. Because new object should be valid right after initialization.
If it MR interested I can try to find other places where we can use setters.
See merge request !6763
Diffstat (limited to 'app/models/commit.rb')
0 files changed, 0 insertions, 0 deletions