diff options
| author | Robert Speicher <rspeicher@gmail.com> | 2015-05-02 22:41:37 -0400 |
|---|---|---|
| committer | Robert Speicher <rspeicher@gmail.com> | 2015-05-26 15:48:29 -0400 |
| commit | 38cd3d64514655c508eba980b7abc216ef2a1c0b (patch) | |
| tree | 89eb6f32bae11b6a76ab83c2de9a5f3b071b143f /app/models/commit.rb | |
| parent | 0ec1e4c028b6e663929b38f1c90f4158f9a49cc2 (diff) | |
| download | gitlab-ce-38cd3d64514655c508eba980b7abc216ef2a1c0b.tar.gz | |
Add Commit#==
Prior, comparison would use the Ruby object's ID, which got out of sync
after a Spring fork and would result in erroneous test failures.
Now we just check that the compared object is a Commit and then compare
their underlying raw commit objects.
Diffstat (limited to 'app/models/commit.rb')
| -rw-r--r-- | app/models/commit.rb | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/app/models/commit.rb b/app/models/commit.rb index be5a118bfec..5dea7dda513 100644 --- a/app/models/commit.rb +++ b/app/models/commit.rb @@ -56,6 +56,10 @@ class Commit @raw.id end + def ==(other) + (self.class === other) && (raw == other.raw) + end + def diff_line_count @diff_line_count ||= Commit::diff_line_count(self.diffs) @diff_line_count |