diff options
author | blackst0ne <blackst0ne.ru@gmail.com> | 2018-05-02 08:09:19 +0000 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2018-05-02 08:09:19 +0000 |
commit | 9e78b86dd48ee893c950643d6ca0188a4978eeaa (patch) | |
tree | 4f944de0c0ae7e5a6b5bc83993d4e557244c8594 /app/models/commit_status.rb | |
parent | 1350d80ca2f2633c8104460c4b9a60eb189a767b (diff) | |
download | gitlab-ce-9e78b86dd48ee893c950643d6ca0188a4978eeaa.tar.gz |
[Rails5] Fix enum question mark methods
Diffstat (limited to 'app/models/commit_status.rb')
-rw-r--r-- | app/models/commit_status.rb | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/app/models/commit_status.rb b/app/models/commit_status.rb index b6276c2fb50..97d89422594 100644 --- a/app/models/commit_status.rb +++ b/app/models/commit_status.rb @@ -189,4 +189,11 @@ class CommitStatus < ActiveRecord::Base v =~ /\d+/ ? v.to_i : v end end + + # Rails 5.0 autogenerated question mark enum methods return wrong result if enum value is nil. + # They always return `false`. + # This method overwrites the autogenerated one to return correct result. + def unknown_failure? + Gitlab.rails5? ? failure_reason.nil? : super + end end |