diff options
author | Shinya Maeda <shinya@gitlab.com> | 2018-06-12 13:13:03 +0900 |
---|---|---|
committer | Shinya Maeda <shinya@gitlab.com> | 2018-06-12 13:13:03 +0900 |
commit | d7a3180d06e7b16728d4f23b1e68007c9c2f3b9a (patch) | |
tree | d111815ee462b6dd0b29af9c158d7d1abc24f505 /app/models/commit_status.rb | |
parent | 644529590a263f8db215d288c2f59abbe632a09b (diff) | |
parent | 26c9d71666d0350b17431a75d8c31d0316bd7220 (diff) | |
download | gitlab-ce-d7a3180d06e7b16728d4f23b1e68007c9c2f3b9a.tar.gz |
Merge branch 'master' into build-chunks-on-object-storage
Diffstat (limited to 'app/models/commit_status.rb')
-rw-r--r-- | app/models/commit_status.rb | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/app/models/commit_status.rb b/app/models/commit_status.rb index a7d05722287..97516079b66 100644 --- a/app/models/commit_status.rb +++ b/app/models/commit_status.rb @@ -3,6 +3,7 @@ class CommitStatus < ActiveRecord::Base include Importable include AfterCommitQueue include Presentable + include EnumWithNil self.table_name = 'ci_builds' @@ -39,7 +40,7 @@ class CommitStatus < ActiveRecord::Base scope :retried_ordered, -> { retried.ordered.includes(project: :namespace) } scope :after_stage, -> (index) { where('stage_idx > ?', index) } - enum failure_reason: { + enum_with_nil failure_reason: { unknown_failure: nil, script_failure: 1, api_failure: 2, @@ -190,11 +191,4 @@ class CommitStatus < ActiveRecord::Base v =~ /\d+/ ? v.to_i : v end end - - # Rails 5.0 autogenerated question mark enum methods return wrong result if enum value is nil. - # They always return `false`. - # This method overwrites the autogenerated one to return correct result. - def unknown_failure? - Gitlab.rails5? ? failure_reason.nil? : super - end end |