diff options
author | Alexandru Croitor <acroitor@gitlab.com> | 2019-05-27 12:42:58 +0300 |
---|---|---|
committer | Alexandru Croitor <acroitor@gitlab.com> | 2019-06-04 13:10:38 +0300 |
commit | 9797b27e1a096f684b870e55aab0b5d1250e73f8 (patch) | |
tree | 91183e82cfeb6159c4946820c584be63b9fe217d /app/models/concerns/milestoneish.rb | |
parent | 3ef47ac83409cc7e00f7ef80d7cae0434e29ccd2 (diff) | |
download | gitlab-ce-9797b27e1a096f684b870e55aab0b5d1250e73f8.tar.gz |
Adjust burndown chart opened issues countce-9578-adjust-opened-issues-count-and-completion-rate
* Adjust opened issues count in the milestone burndown chart
to match current opened issues in the milestone.
* Fix completion rate calculation to include milestones only.
Diffstat (limited to 'app/models/concerns/milestoneish.rb')
-rw-r--r-- | app/models/concerns/milestoneish.rb | 20 |
1 files changed, 6 insertions, 14 deletions
diff --git a/app/models/concerns/milestoneish.rb b/app/models/concerns/milestoneish.rb index e65bbb8ca07..3deb86da6cf 100644 --- a/app/models/concerns/milestoneish.rb +++ b/app/models/concerns/milestoneish.rb @@ -1,28 +1,20 @@ # frozen_string_literal: true module Milestoneish - def closed_items_count(user) - memoize_per_user(user, :closed_items_count) do - (count_issues_by_state(user)['closed'] || 0) + merge_requests.closed_and_merged.size - end - end - - def total_items_count(user) - memoize_per_user(user, :total_items_count) do - total_issues_count(user) + merge_requests.size - end - end - def total_issues_count(user) count_issues_by_state(user).values.sum end + def closed_issues_count(user) + count_issues_by_state(user)['closed'].to_i + end + def complete?(user) - total_items_count(user) > 0 && total_items_count(user) == closed_items_count(user) + total_issues_count(user) > 0 && total_issues_count(user) == closed_issues_count(user) end def percent_complete(user) - ((closed_items_count(user) * 100) / total_items_count(user)).abs + closed_issues_count(user) * 100 / total_issues_count(user) rescue ZeroDivisionError 0 end |