diff options
author | Małgorzata Ksionek <mksionek@gitlab.com> | 2019-07-08 10:26:02 +0200 |
---|---|---|
committer | Małgorzata Ksionek <mksionek@gitlab.com> | 2019-07-09 12:16:38 +0200 |
commit | f6423fa468e267d27594c3a0190bc9d2166d0e9c (patch) | |
tree | 008bf07f12dcacedadf490c4fffc40cb3a32449c /app/models/cycle_analytics | |
parent | 08cf6fccfdac197e6ef10b12a5a9015e7f453ed2 (diff) | |
download | gitlab-ce-f6423fa468e267d27594c3a0190bc9d2166d0e9c.tar.gz |
Add code review remarks
Diffstat (limited to 'app/models/cycle_analytics')
-rw-r--r-- | app/models/cycle_analytics/base.rb | 14 | ||||
-rw-r--r-- | app/models/cycle_analytics/project_level.rb | 2 |
2 files changed, 5 insertions, 11 deletions
diff --git a/app/models/cycle_analytics/base.rb b/app/models/cycle_analytics/base.rb index 240be10c1f9..d7b28cd1b67 100644 --- a/app/models/cycle_analytics/base.rb +++ b/app/models/cycle_analytics/base.rb @@ -4,14 +4,16 @@ module CycleAnalytics class Base STAGES = %i[issue plan code test review staging production].freeze - def all_medians_per_stage + def all_medians_by_stage STAGES.each_with_object({}) do |stage_name, medians_per_stage| medians_per_stage[stage_name] = self[stage_name].median end end def stats - @stats ||= stats_per_stage + @stats ||= STAGES.map do |stage_name| + self[stage_name].as_json + end end def no_stats? @@ -21,13 +23,5 @@ module CycleAnalytics def [](stage_name) Gitlab::CycleAnalytics::Stage[stage_name].new(project: @project, options: @options) end - - private - - def stats_per_stage - STAGES.map do |stage_name| - self[stage_name].as_json - end - end end end diff --git a/app/models/cycle_analytics/project_level.rb b/app/models/cycle_analytics/project_level.rb index 93c4b64ba3e..b0812d40ffa 100644 --- a/app/models/cycle_analytics/project_level.rb +++ b/app/models/cycle_analytics/project_level.rb @@ -2,7 +2,7 @@ module CycleAnalytics class ProjectLevel < Base - def initialize(project:, options:) + def initialize(project, options:) @project = project @options = options end |