diff options
| author | Sean McGivern <sean@gitlab.com> | 2018-04-09 12:19:18 +0100 |
|---|---|---|
| committer | Sean McGivern <sean@gitlab.com> | 2018-04-09 12:47:04 +0100 |
| commit | 4ef3e3491e2ecc34e7f4de1221d5ad7b8b4a1e24 (patch) | |
| tree | 6c151944cf2791fe4526633603f3e888268ae431 /app/models/deploy_token.rb | |
| parent | 20fdbbe86a6cffbf467f08d50a0d8ef0f5c87f50 (diff) | |
| download | gitlab-ce-4ef3e3491e2ecc34e7f4de1221d5ad7b8b4a1e24.tar.gz | |
Add cop for has_many :through without disabled autoloadingfix-n-plus-one-when-getting-notification-settings-for-recipients
Goldiloader is great, but has several issues with has_many :through relations:
* https://github.com/salsify/goldiloader/issues/12
* https://github.com/salsify/goldiloader/issues/14
* https://github.com/salsify/goldiloader/issues/18
Rather than try to figure out which applies in each case, we should just do the
drudge work of manually disabling autoloading for all relations of this type. We
can always use regular preloading for specific cases, but this way we avoid
generating invalid queries through Goldiloader's magic.
Diffstat (limited to 'app/models/deploy_token.rb')
| -rw-r--r-- | app/models/deploy_token.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/models/deploy_token.rb b/app/models/deploy_token.rb index fe726b156d4..b47b2ff4c3f 100644 --- a/app/models/deploy_token.rb +++ b/app/models/deploy_token.rb @@ -8,7 +8,7 @@ class DeployToken < ActiveRecord::Base default_value_for(:expires_at) { Forever.date } has_many :project_deploy_tokens, inverse_of: :deploy_token - has_many :projects, through: :project_deploy_tokens + has_many :projects, -> { auto_include(false) }, through: :project_deploy_tokens validate :ensure_at_least_one_scope before_save :ensure_token |