Make `DiffNote#update_position` private

1 files changed, 14 insertions, 19 deletions

diff --git a/app/models/diff_note.rb b/app/models/diff_note.rb
index cdd1c4b4aef..9671955db36 100644
--- a/app/models/diff_note.rb
+++ b/app/models/diff_note.rb
@@ -72,6 +72,20 @@ class DiffNote < Note
     self.position.diff_refs == diff_refs
   end
 
+  private
+
+  def supported?
+    !self.for_merge_request? || self.noteable.support_new_diff_notes?
+  end
+
+  def set_original_position
+    self.original_position = self.position.dup
+  end
+
+  def set_line_code
+    self.line_code = self.position.line_code(self.project.repository)
+  end
+
   def update_position
     return unless supported?
     return if for_commit?
@@ -87,25 +101,6 @@ class DiffNote < Note
     ).execute(self)
   end
 
-  def update_position!
-    update_position &&
-      Gitlab::Timeless.timeless(self, &:save)
-  end
-
-  private
-
-  def supported?
-    !self.for_merge_request? || self.noteable.support_new_diff_notes?
-  end
-
-  def set_original_position
-    self.original_position = self.position.dup
-  end
-
-  def set_line_code
-    self.line_code = self.position.line_code(self.project.repository)
-  end
-
   def verify_supported
     return if supported?