diff options
author | Douwe Maan <douwe@selenight.nl> | 2016-07-07 16:13:55 -0400 |
---|---|---|
committer | Douwe Maan <douwe@selenight.nl> | 2016-07-07 16:13:55 -0400 |
commit | 6dd71888b310d2615d74ea129431fc6c9791b6b7 (patch) | |
tree | cee4fe55b4a85f89e0bd5707a6247f78dc15a171 /app/models/diff_note.rb | |
parent | 70a64f6a57a2b4fd2874b0db03f4fe1f0c3794f8 (diff) | |
download | gitlab-ce-6dd71888b310d2615d74ea129431fc6c9791b6b7.tar.gz |
Make `DiffNote#update_position` private
Diffstat (limited to 'app/models/diff_note.rb')
-rw-r--r-- | app/models/diff_note.rb | 33 |
1 files changed, 14 insertions, 19 deletions
diff --git a/app/models/diff_note.rb b/app/models/diff_note.rb index cdd1c4b4aef..9671955db36 100644 --- a/app/models/diff_note.rb +++ b/app/models/diff_note.rb @@ -72,6 +72,20 @@ class DiffNote < Note self.position.diff_refs == diff_refs end + private + + def supported? + !self.for_merge_request? || self.noteable.support_new_diff_notes? + end + + def set_original_position + self.original_position = self.position.dup + end + + def set_line_code + self.line_code = self.position.line_code(self.project.repository) + end + def update_position return unless supported? return if for_commit? @@ -87,25 +101,6 @@ class DiffNote < Note ).execute(self) end - def update_position! - update_position && - Gitlab::Timeless.timeless(self, &:save) - end - - private - - def supported? - !self.for_merge_request? || self.noteable.support_new_diff_notes? - end - - def set_original_position - self.original_position = self.position.dup - end - - def set_line_code - self.line_code = self.position.line_code(self.project.repository) - end - def verify_supported return if supported? |