diff options
| author | Timothy Andrew <mail@timothyandrew.net> | 2016-09-20 15:06:54 +0530 |
|---|---|---|
| committer | Timothy Andrew <mail@timothyandrew.net> | 2016-09-20 16:05:25 +0530 |
| commit | 8957293d9bd0d711db3af26182205c2fe4125194 (patch) | |
| tree | dcdd25393e2d6248971fddbd6c9eac30fe27ff6e /app/models/issue.rb | |
| parent | fa890604aaf15b9e4f0199e6a4cff24c29955a37 (diff) | |
| download | gitlab-ce-8957293d9bd0d711db3af26182205c2fe4125194.tar.gz | |
Implement review comments from @yorickpeterse
1. Change multiple updates to a single `update_all`
2. Use cascading deletes
3. Extract an average function for the database median.
4. Move database median to `lib/gitlab/database`
5. Use `delete_all` instead of `destroy_all`
6. Minor refactoring
Diffstat (limited to 'app/models/issue.rb')
| -rw-r--r-- | app/models/issue.rb | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/app/models/issue.rb b/app/models/issue.rb index 2403748d017..06af94adf5e 100644 --- a/app/models/issue.rb +++ b/app/models/issue.rb @@ -23,9 +23,9 @@ class Issue < ActiveRecord::Base has_many :events, as: :target, dependent: :destroy - has_one :metrics, dependent: :destroy + has_one :metrics - has_many :merge_requests_closing_issues, class_name: MergeRequestsClosingIssues + has_many :merge_requests_closing_issues, class_name: 'MergeRequestsClosingIssues' has_many :closed_by_merge_requests, through: :merge_requests_closing_issues, source: :merge_request validates :project, presence: true @@ -202,7 +202,7 @@ class Issue < ActiveRecord::Base # From all notes on this issue, we'll select the system notes about linked # merge requests. Of those, the MRs closing `self` are returned. def closed_by_merge_requests(current_user = nil) - return [] if !open? + return [] unless open? ext = all_references(current_user) |