diff options
author | Douwe Maan <douwe@selenight.nl> | 2017-04-06 10:05:57 -0500 |
---|---|---|
committer | Douwe Maan <douwe@selenight.nl> | 2017-04-06 10:51:45 -0500 |
commit | cc656a11992483911cefe035d579096581cfde57 (patch) | |
tree | 5af4a41d9ae36b3900fdfa0b312b125995c8818c /app/models/legacy_diff_discussion.rb | |
parent | 64c1735c22871d94e0bda8b9f5aece2a29739236 (diff) | |
download | gitlab-ce-cc656a11992483911cefe035d579096581cfde57.tar.gz |
Refactor resolvability checks based on type
Diffstat (limited to 'app/models/legacy_diff_discussion.rb')
-rw-r--r-- | app/models/legacy_diff_discussion.rb | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/app/models/legacy_diff_discussion.rb b/app/models/legacy_diff_discussion.rb index 6515762c92d..cb2651a03f8 100644 --- a/app/models/legacy_diff_discussion.rb +++ b/app/models/legacy_diff_discussion.rb @@ -1,6 +1,9 @@ # A discussion on merge request or commit diffs consisting of `LegacyDiffNote` notes. +# # All new diff discussions are of the type `DiffDiscussion`, but any diff discussions created # before the introduction of the new implementation still use `LegacyDiffDiscussion`. +# +# A discussion of this type is never resolvable. class LegacyDiffDiscussion < Discussion include DiscussionOnDiff @@ -8,8 +11,8 @@ class LegacyDiffDiscussion < Discussion true end - def potentially_resolvable? - false + def self.note_class + LegacyDiffNote end def collapsed? |