diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-03-02 09:31:36 -0800 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-03-06 07:03:46 -0800 |
| commit | 062efe4f7a83fb2b6d951b314692cca9ee8731cd (patch) | |
| tree | 2907359acdf497130b38c75555056226189af829 /app/models/merge_request.rb | |
| parent | a592a78072bb44fed1a25c25f2cabdc4cf4bc0bd (diff) | |
| download | gitlab-ce-062efe4f7a83fb2b6d951b314692cca9ee8731cd.tar.gz | |
Significantly reduce N+1 queries in /api/v4/todos endpoint
By preloading associations and batching issuable metadata lookups,
we can significantly cut the number of SQL queries needed to load
the Todos API endpoint.
On GitLab.com, my own tests showed my user's SQL queries went
from 365 to under 60 SQL queries.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/40378
Diffstat (limited to 'app/models/merge_request.rb')
| -rw-r--r-- | app/models/merge_request.rb | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/app/models/merge_request.rb b/app/models/merge_request.rb index b67797f5404..acf80addc6a 100644 --- a/app/models/merge_request.rb +++ b/app/models/merge_request.rb @@ -184,6 +184,13 @@ class MergeRequest < ActiveRecord::Base scope :assigned, -> { where("assignee_id IS NOT NULL") } scope :unassigned, -> { where("assignee_id IS NULL") } scope :assigned_to, ->(u) { where(assignee_id: u.id)} + scope :with_api_entity_associations, -> { + preload(:author, :assignee, :notes, :labels, :milestone, :timelogs, + latest_merge_request_diff: [:merge_request_diff_commits], + metrics: [:latest_closed_by, :merged_by], + target_project: [:route, { namespace: :route }], + source_project: [:route, { namespace: :route }]) + } participant :assignee |