diff options
| author | Jan Provaznik <jprovaznik@gitlab.com> | 2019-09-06 11:54:58 +0200 |
|---|---|---|
| committer | Jan Provaznik <jprovaznik@gitlab.com> | 2019-09-07 06:43:17 +0200 |
| commit | f2754e416e16c1b56810b835505346c295578c7a (patch) | |
| tree | 42867740b585563f6569e5b9a46071c67466e5bc /app/models/milestone.rb | |
| parent | 093858adc76f893c35b0bcf25127c3f229a7bcb6 (diff) | |
| download | gitlab-ce-f2754e416e16c1b56810b835505346c295578c7a.tar.gz | |
Use delete_all for deleting eventsevents-delete-all
Because we don't have any destroy callbacks (or other logic
triggered on event destroy), there is no reason for deleting events
inefficiently one by one, instead we can use :delete_all.
Diffstat (limited to 'app/models/milestone.rb')
| -rw-r--r-- | app/models/milestone.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/models/milestone.rb b/app/models/milestone.rb index 915978d37b8..7f46e5faf1a 100644 --- a/app/models/milestone.rb +++ b/app/models/milestone.rb @@ -37,7 +37,7 @@ class Milestone < ApplicationRecord has_many :issues has_many :labels, -> { distinct.reorder('labels.title') }, through: :issues has_many :merge_requests - has_many :events, as: :target, dependent: :destroy # rubocop:disable Cop/ActiveRecordDependent + has_many :events, as: :target, dependent: :delete_all # rubocop:disable Cop/ActiveRecordDependent scope :of_projects, ->(ids) { where(project_id: ids) } scope :of_groups, ->(ids) { where(group_id: ids) } |