Address Yorick's feedbackeReGeBe/gitlab-ce-feature/milestone-md

Signed-off-by: Rémy Coutable <remy@rymai.me>

1 files changed, 2 insertions, 2 deletions

diff --git a/app/models/milestone.rb b/app/models/milestone.rb
index 31a54f44453..e0c8454a998 100644
--- a/app/models/milestone.rb
+++ b/app/models/milestone.rb
@@ -67,7 +67,7 @@ class Milestone < ActiveRecord::Base
     # NOTE: The iid pattern only matches when all characters on the expression
     # are digits, so it will match %2 but not %2.1 because that's probably a
     # milestone name and we want it to be matched as such.
-    %r{
+    @reference_pattern ||= %r{
       (#{Project.reference_pattern})?
       #{Regexp.escape(reference_prefix)}
       (?:
@@ -195,7 +195,7 @@ class Milestone < ActiveRecord::Base
   private
 
   def milestone_format_reference(format = :iid)
-    raise StandardError, 'Unknown format' unless [:iid, :name].include?(format)
+    raise ArgumentError, 'Unknown format' unless [:iid, :name].include?(format)
 
     if format == :name && !name.include?('"')
       %("#{name}")