Fix couple of moments in HangoutsChatService and its spec

1 files changed, 7 insertions, 5 deletions

diff --git a/app/models/project_services/hangouts_chat_service.rb b/app/models/project_services/hangouts_chat_service.rb
index 53f11c424e3..a8512c5f57c 100644
--- a/app/models/project_services/hangouts_chat_service.rb
+++ b/app/models/project_services/hangouts_chat_service.rb
@@ -44,20 +44,22 @@ class HangoutsChatService < ChatNotificationService
   private
 
   def notify(message, opts)
-    simple_text = compose_simple_message(message)
+    simple_text = parse_simple_text_message(message)
     HangoutsChat::Sender.new(webhook).simple(simple_text)
   end
 
-  def compose_simple_message(message)
+  def parse_simple_text_message(message)
     header = message.pretext
     return header if message.attachments.empty?
 
-    title = fetch_attachment_title(message.attachments.first)
-    body = message.attachments.first[:text]
+    attachment = message.attachments.first
+    title      = format_attachment_title(attachment)
+    body       = attachment[:text]
+
     [header, title, body].compact.join("\n")
   end
 
-  def fetch_attachment_title(attachment)
+  def format_attachment_title(attachment)
     return attachment[:title] unless attachment[:title_link]
 
     "<#{attachment[:title_link]}|#{attachment[:title]}>"