summaryrefslogtreecommitdiff
path: root/app/models/todo.rb
diff options
context:
space:
mode:
authorYorick Peterse <yorickpeterse@gmail.com>2017-06-02 14:29:30 +0200
committerYorick Peterse <yorickpeterse@gmail.com>2017-06-07 17:36:55 +0200
commit5819ca1a249d1daf3b4feb655c217c98a1b70225 (patch)
tree799459af23e425921e5368693ee3d0a258c426bb /app/models/todo.rb
parent44d65c36dbe2f38eacb1858a99996c025b755937 (diff)
downloadgitlab-ce-5819ca1a249d1daf3b4feb655c217c98a1b70225.tar.gz
Added Cop to blacklist polymorphic associations
One should really use a separate table instead of using polymorphic associations. See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11168 for more information.
Diffstat (limited to 'app/models/todo.rb')
-rw-r--r--app/models/todo.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/app/models/todo.rb b/app/models/todo.rb
index b011001b235..696d139af74 100644
--- a/app/models/todo.rb
+++ b/app/models/todo.rb
@@ -22,7 +22,7 @@ class Todo < ActiveRecord::Base
belongs_to :author, class_name: "User"
belongs_to :note
belongs_to :project
- belongs_to :target, polymorphic: true, touch: true
+ belongs_to :target, polymorphic: true, touch: true # rubocop:disable Cop/PolymorphicAssociations
belongs_to :user
delegate :name, :email, to: :author, prefix: true, allow_nil: true