Use SQL::Union for User#authorized_groups

This removes the need for plucking any IDs into Ruby.

1 files changed, 7 insertions, 4 deletions

diff --git a/app/models/user.rb b/app/models/user.rb
index 8f34f52be1d..ddb3158e0f5 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -391,10 +391,13 @@ class User < ActiveRecord::Base
 
   # Groups user has access to
   def authorized_groups
-    @authorized_groups ||= begin
-                             group_ids = (groups.pluck(:id) + authorized_projects.pluck(:namespace_id))
-                             Group.where(id: group_ids)
-                           end
+    @authorized_groups ||=
+      begin
+        union = Gitlab::SQL::Union.
+          new([groups.select(:id), authorized_projects.select(:namespace_id)])
+
+        Group.where("id IN (#{union.to_sql})")
+      end
   end
 
   # Projects user has access to