diff options
author | Douwe Maan <douwe@selenight.nl> | 2017-02-22 09:10:32 -0600 |
---|---|---|
committer | Douwe Maan <douwe@selenight.nl> | 2017-02-23 09:31:57 -0600 |
commit | 5c7f9d69e3db27921acf6d8259245f2b4babcc2b (patch) | |
tree | b90334ce234ddd3921e0f1780cf3bb0848adff7b /app/models | |
parent | 02494f7ce86fbf1276b384f45f58558c427eff63 (diff) | |
download | gitlab-ce-5c7f9d69e3db27921acf6d8259245f2b4babcc2b.tar.gz |
Fix code for cops
Diffstat (limited to 'app/models')
-rw-r--r-- | app/models/commit.rb | 11 | ||||
-rw-r--r-- | app/models/concerns/case_sensitivity.rb | 11 | ||||
-rw-r--r-- | app/models/concerns/sortable.rb | 11 | ||||
-rw-r--r-- | app/models/network/graph.rb | 11 | ||||
-rw-r--r-- | app/models/project.rb | 15 | ||||
-rw-r--r-- | app/models/project_services/pushover_service.rb | 15 |
6 files changed, 40 insertions, 34 deletions
diff --git a/app/models/commit.rb b/app/models/commit.rb index feb35bb3e92..8f6179f183e 100644 --- a/app/models/commit.rb +++ b/app/models/commit.rb @@ -122,11 +122,12 @@ class Commit def full_title return @full_title if @full_title - @full_title = if safe_message.blank? - no_commit_message - else - safe_message.split("\n", 2).first - end + @full_title = + if safe_message.blank? + no_commit_message + else + safe_message.split("\n", 2).first + end end # Returns the commits description diff --git a/app/models/concerns/case_sensitivity.rb b/app/models/concerns/case_sensitivity.rb index 2cfb6127c96..034e9f40ff0 100644 --- a/app/models/concerns/case_sensitivity.rb +++ b/app/models/concerns/case_sensitivity.rb @@ -13,11 +13,12 @@ module CaseSensitivity params.each do |key, value| column = ActiveRecord::Base.connection.quote_table_name(key) - condition = if cast_lower - "LOWER(#{column}) = LOWER(:value)" - else - "#{column} = :value" - end + condition = + if cast_lower + "LOWER(#{column}) = LOWER(:value)" + else + "#{column} = :value" + end criteria = criteria.where(condition, value: value) end diff --git a/app/models/concerns/sortable.rb b/app/models/concerns/sortable.rb index fdcb4f3ba64..b9a2d812edd 100644 --- a/app/models/concerns/sortable.rb +++ b/app/models/concerns/sortable.rb @@ -46,11 +46,12 @@ module Sortable where("label_links.target_id = #{target_column}"). reorder(nil) - query = if target_type_column - query.where("label_links.target_type = #{target_type_column}") - else - query.where(label_links: { target_type: target_type }) - end + query = + if target_type_column + query.where("label_links.target_type = #{target_type_column}") + else + query.where(label_links: { target_type: target_type }) + end query = query.where.not(title: excluded_labels) if excluded_labels.present? diff --git a/app/models/network/graph.rb b/app/models/network/graph.rb index b859d40da24..2a7fa7d0607 100644 --- a/app/models/network/graph.rb +++ b/app/models/network/graph.rb @@ -188,11 +188,12 @@ module Network end # and mark it as reserved - min_time = if parent_time.nil? - leaves.first.time - else - parent_time + 1 - end + min_time = + if parent_time.nil? + leaves.first.time + else + parent_time + 1 + end max_time = leaves.last.time leaves.last.parents(@map).each do |parent| diff --git a/app/models/project.rb b/app/models/project.rb index a0bc82af7d5..e75ba3abb98 100644 --- a/app/models/project.rb +++ b/app/models/project.rb @@ -453,13 +453,14 @@ class Project < ActiveRecord::Base end def add_import_job - job_id = if forked? - RepositoryForkWorker.perform_async(id, forked_from_project.repository_storage_path, - forked_from_project.path_with_namespace, - self.namespace.full_path) - else - RepositoryImportWorker.perform_async(self.id) - end + job_id = + if forked? + RepositoryForkWorker.perform_async(id, forked_from_project.repository_storage_path, + forked_from_project.path_with_namespace, + self.namespace.full_path) + else + RepositoryImportWorker.perform_async(self.id) + end if job_id Rails.logger.info "Import job started for #{path_with_namespace} with job ID #{job_id}" diff --git a/app/models/project_services/pushover_service.rb b/app/models/project_services/pushover_service.rb index cd185f6e120..f4106048345 100644 --- a/app/models/project_services/pushover_service.rb +++ b/app/models/project_services/pushover_service.rb @@ -72,13 +72,14 @@ class PushoverService < Service before = data[:before] after = data[:after] - message = if Gitlab::Git.blank_ref?(before) - "#{data[:user_name]} pushed new branch \"#{ref}\"." - elsif Gitlab::Git.blank_ref?(after) - "#{data[:user_name]} deleted branch \"#{ref}\"." - else - "#{data[:user_name]} push to branch \"#{ref}\"." - end + message = + if Gitlab::Git.blank_ref?(before) + "#{data[:user_name]} pushed new branch \"#{ref}\"." + elsif Gitlab::Git.blank_ref?(after) + "#{data[:user_name]} deleted branch \"#{ref}\"." + else + "#{data[:user_name]} push to branch \"#{ref}\"." + end if data[:total_commits_count] > 0 message << "\nTotal commits count: #{data[:total_commits_count]}" |