diff options
author | Sean McGivern <sean@mcgivern.me.uk> | 2017-04-24 18:36:17 +0000 |
---|---|---|
committer | Sean McGivern <sean@mcgivern.me.uk> | 2017-04-24 18:36:17 +0000 |
commit | 375746d6fc308dc16875750bc9342196166d28a6 (patch) | |
tree | 8f70d10ea870c5d3b1f9ed8e9a224560a321170a /app/models | |
parent | 1884f650ac4f34f1c0883112a4e3ce22caac869d (diff) | |
parent | bc4eeb96ae5c7de96f7e8e16aa508e3308f06c5b (diff) | |
download | gitlab-ce-375746d6fc308dc16875750bc9342196166d28a6.tar.gz |
Merge branch 'dm-fix-individual-notes-reply-attributes' into 'master'
Ensure replying to an individual note by email creates a note with its own discussion ID
Closes #31067
See merge request !10890
Diffstat (limited to 'app/models')
-rw-r--r-- | app/models/individual_note_discussion.rb | 4 | ||||
-rw-r--r-- | app/models/out_of_context_discussion.rb | 6 |
2 files changed, 9 insertions, 1 deletions
diff --git a/app/models/individual_note_discussion.rb b/app/models/individual_note_discussion.rb index c3f21c55240..6be8ca45739 100644 --- a/app/models/individual_note_discussion.rb +++ b/app/models/individual_note_discussion.rb @@ -10,4 +10,8 @@ class IndividualNoteDiscussion < Discussion def individual_note? true end + + def reply_attributes + super.tap { |attrs| attrs.delete(:discussion_id) } + end end diff --git a/app/models/out_of_context_discussion.rb b/app/models/out_of_context_discussion.rb index 85794630f70..4227c40b69a 100644 --- a/app/models/out_of_context_discussion.rb +++ b/app/models/out_of_context_discussion.rb @@ -15,8 +15,12 @@ class OutOfContextDiscussion < Discussion def self.override_discussion_id(note) discussion_id(note) end - + def self.note_class Note end + + def reply_attributes + super.tap { |attrs| attrs.delete(:discussion_id) } + end end |