summaryrefslogtreecommitdiff
path: root/app/models
diff options
context:
space:
mode:
authorGrzegorz Bizon <grzesiek.bizon@gmail.com>2017-05-08 12:47:21 +0200
committerGrzegorz Bizon <grzesiek.bizon@gmail.com>2017-06-20 15:32:29 +0200
commit64e09a1b35cc1897df7e46e73989c6e7013f6196 (patch)
treeb3536db28e29f337237bcbe413c29bbf66471cd0 /app/models
parentbf57a7e80c44080dc7ec0fd774148afdae29cc31 (diff)
downloadgitlab-ce-64e09a1b35cc1897df7e46e73989c6e7013f6196.tar.gz
Fix pipeline status when allowed to fail jobs present
Diffstat (limited to 'app/models')
-rw-r--r--app/models/concerns/has_status.rb4
1 files changed, 3 insertions, 1 deletions
diff --git a/app/models/concerns/has_status.rb b/app/models/concerns/has_status.rb
index 3c9c6584e02..692bd1f9317 100644
--- a/app/models/concerns/has_status.rb
+++ b/app/models/concerns/has_status.rb
@@ -37,7 +37,9 @@ module HasStatus
end
def status
- all.pluck(status_sql).first
+ all.pluck(status_sql).first.tap do |status|
+ return 'success' if status == 'skipped' && all.failed_but_allowed.any?
+ end
end
def started_at