Encapsulate reused pagination component in a class

1 files changed, 10 insertions, 27 deletions

diff --git a/app/serializers/pipeline_serializer.rb b/app/serializers/pipeline_serializer.rb
index b2de6c5832e..7c8dfad3b4b 100644
--- a/app/serializers/pipeline_serializer.rb
+++ b/app/serializers/pipeline_serializer.rb
@@ -1,41 +1,24 @@
 class PipelineSerializer < BaseSerializer
   class InvalidResourceError < StandardError; end
-  include API::Helpers::Pagination
-  Struct.new('Pagination', :request, :response)
 
   entity PipelineEntity
 
+  def with_pagination(request, response)
+    tap { @paginator = Paginator.new(request, response) }
+  end
+
+  def paginated?
+    defined?(@paginator)
+  end
+
   def represent(resource, opts = {})
     if paginated?
       raise InvalidResourceError unless resource.respond_to?(:page)
 
-      super(paginate(resource.includes(project: :namespace)), opts)
+      resource = resource.includes(project: :namespace)
+      super(@paginator.paginate(resource), opts)
     else
       super(resource, opts)
     end
   end
-
-  def paginated?
-    defined?(@pagination)
-  end
-
-  def with_pagination(request, response)
-    tap { @pagination = Struct::Pagination.new(request, response) }
-  end
-
-  private
-
-  # Methods needed by `API::Helpers::Pagination`
-  #
-  def params
-    @pagination.request.query_parameters
-  end
-
-  def request
-    @pagination.request
-  end
-
-  def header(header, value)
-    @pagination.response.headers[header] = value
-  end
 end