summaryrefslogtreecommitdiff
path: root/app/services/boards
diff options
context:
space:
mode:
authorGitLab Bot <gitlab-bot@gitlab.com>2022-08-18 08:17:02 +0000
committerGitLab Bot <gitlab-bot@gitlab.com>2022-08-18 08:17:02 +0000
commitb39512ed755239198a9c294b6a45e65c05900235 (patch)
treed234a3efade1de67c46b9e5a38ce813627726aa7 /app/services/boards
parentd31474cf3b17ece37939d20082b07f6657cc79a9 (diff)
downloadgitlab-ce-b39512ed755239198a9c294b6a45e65c05900235.tar.gz
Add latest changes from gitlab-org/gitlab@15-3-stable-eev15.3.0-rc42
Diffstat (limited to 'app/services/boards')
-rw-r--r--app/services/boards/destroy_service.rb4
-rw-r--r--app/services/boards/lists/move_service.rb2
2 files changed, 1 insertions, 5 deletions
diff --git a/app/services/boards/destroy_service.rb b/app/services/boards/destroy_service.rb
index 0b1cd61b119..ceda005044e 100644
--- a/app/services/boards/destroy_service.rb
+++ b/app/services/boards/destroy_service.rb
@@ -3,10 +3,6 @@
module Boards
class DestroyService < Boards::BaseService
def execute(board)
- if boards.size == 1
- return ServiceResponse.error(message: "The board could not be deleted, because the parent doesn't have any other boards.")
- end
-
board.destroy!
ServiceResponse.success
diff --git a/app/services/boards/lists/move_service.rb b/app/services/boards/lists/move_service.rb
index 93f81837d1a..4bb7b4dbc6d 100644
--- a/app/services/boards/lists/move_service.rb
+++ b/app/services/boards/lists/move_service.rb
@@ -23,7 +23,7 @@ module Boards
def valid_move?
new_position.present? && new_position != old_position &&
- new_position >= 0 && new_position < board.lists.movable.size
+ new_position >= 0 && new_position <= board.lists.movable.last.position
end
def reorder_intermediate_lists