summaryrefslogtreecommitdiff
path: root/app/services/boards
diff options
context:
space:
mode:
authorBrett Walker <bwalker@gitlab.com>2019-05-31 20:19:08 -0500
committerBrett Walker <bwalker@gitlab.com>2019-06-21 07:05:42 -0500
commit4a85e263b4afe2e1e64dcaf55856add6e7aed764 (patch)
tree91f9d823f7c1b3ecc45ae0b8c20bcd4bf8b69a42 /app/services/boards
parent6fa900547dbd30b0db0070f87dbeb4b05d485b9b (diff)
downloadgitlab-ce-4a85e263b4afe2e1e64dcaf55856add6e7aed764.tar.gz
Add reorder action to Project IssuesControllerbw-issue-reorder
to support manual sorting on the frontend
Diffstat (limited to 'app/services/boards')
-rw-r--r--app/services/boards/issues/move_service.rb6
1 files changed, 4 insertions, 2 deletions
diff --git a/app/services/boards/issues/move_service.rb b/app/services/boards/issues/move_service.rb
index 834baeb9643..e27d34dbcab 100644
--- a/app/services/boards/issues/move_service.rb
+++ b/app/services/boards/issues/move_service.rb
@@ -79,9 +79,11 @@ module Boards
# rubocop: enable CodeReuse/ActiveRecord
def move_between_ids
- return unless params[:move_after_id] || params[:move_before_id]
+ ids = [params[:move_after_id], params[:move_before_id]]
+ .map(&:to_i)
+ .map { |m| m.positive? ? m : nil }
- [params[:move_after_id], params[:move_before_id]]
+ ids.any? ? ids : nil
end
end
end