diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2019-10-21 15:05:58 +0000 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2019-10-21 15:05:58 +0000 |
| commit | ad1e4b8fb8104b642fa79ed34fd144bc2bed8a19 (patch) | |
| tree | 78f95d63d4ea5ed0b1a8b3c83c38d9cbd682f884 /app/services/ci/compare_reports_base_service.rb | |
| parent | 664c4c7b49c6056136299817eb79e9f1de83e567 (diff) | |
| download | gitlab-ce-ad1e4b8fb8104b642fa79ed34fd144bc2bed8a19.tar.gz | |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'app/services/ci/compare_reports_base_service.rb')
| -rw-r--r-- | app/services/ci/compare_reports_base_service.rb | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/app/services/ci/compare_reports_base_service.rb b/app/services/ci/compare_reports_base_service.rb index 5b76e1824e4..83ba70e8437 100644 --- a/app/services/ci/compare_reports_base_service.rb +++ b/app/services/ci/compare_reports_base_service.rb @@ -1,6 +1,11 @@ # frozen_string_literal: true module Ci + # TODO: when using this class with exposed artifacts we see that there are + # 2 responsibilities: + # 1. reactive caching interface (same in all cases) + # 2. data generator (report comparison in most of the case but not always) + # issue: https://gitlab.com/gitlab-org/gitlab/issues/34224 class CompareReportsBaseService < ::BaseService def execute(base_pipeline, head_pipeline) comparer = comparer_class.new(get_report(base_pipeline), get_report(head_pipeline)) |