diff options
author | Stan Hu <stanhu@gmail.com> | 2019-01-09 22:50:51 -0800 |
---|---|---|
committer | Stan Hu <stanhu@gmail.com> | 2019-01-10 01:30:41 -0800 |
commit | 05f30ac6bbb5c6f5dcc7fb045bb8761434290367 (patch) | |
tree | c0f16d225f98957709f7babaef965dc541efd94f /app/services/ci | |
parent | 4a6c7661edae664a7f6366201d017e24d8f42026 (diff) | |
download | gitlab-ce-05f30ac6bbb5c6f5dcc7fb045bb8761434290367.tar.gz |
Disable audit event logging for pipeline destruction
AuditEventService isn't equipped to handle logging of the destruction of
entities such as CI pipelines. It's a project-level event that operates
on a pipeline. The current log doesn't even indicate that the pipeline
is being destroyed.
This is a CE backport of
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9105. We're
removing the auditing call because it breaks the EE implementation.
Diffstat (limited to 'app/services/ci')
-rw-r--r-- | app/services/ci/destroy_pipeline_service.rb | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/app/services/ci/destroy_pipeline_service.rb b/app/services/ci/destroy_pipeline_service.rb index 13f892aabb8..5c4a34043c1 100644 --- a/app/services/ci/destroy_pipeline_service.rb +++ b/app/services/ci/destroy_pipeline_service.rb @@ -5,8 +5,6 @@ module Ci def execute(pipeline) raise Gitlab::Access::AccessDeniedError unless can?(current_user, :destroy_pipeline, pipeline) - AuditEventService.new(current_user, pipeline).security_event - pipeline.destroy! end end |