Let Commits::TagService return a result hash

1 files changed, 7 insertions, 3 deletions

diff --git a/app/services/commits/tag_service.rb b/app/services/commits/tag_service.rb
index fb841655fee..7961ba4d3c4 100644
--- a/app/services/commits/tag_service.rb
+++ b/app/services/commits/tag_service.rb
@@ -3,7 +3,9 @@
 module Commits
   class TagService < BaseService
     def execute(commit)
-      return unless params[:tag_name]
+      unless params[:tag_name]
+        return error('Missing parameter tag_name')
+      end
 
       tag_name = params[:tag_name]
       message = params[:tag_message]
@@ -13,10 +15,12 @@ module Commits
         .new(commit.project, current_user)
         .execute(tag_name, commit.sha, message, release_description)
 
-      if result[:status] == :success && (tag = result[:tag])
+      if result[:status] == :success
+        tag = result[:tag]
         SystemNoteService.tag_commit(commit, commit.project, current_user, tag.name)
-        commit
       end
+
+      result
     end
   end
 end