summaryrefslogtreecommitdiff
path: root/app/services/git_tag_push_service.rb
diff options
context:
space:
mode:
authorGrzegorz Bizon <grzesiek.bizon@gmail.com>2016-05-30 13:46:47 +0200
committerGrzegorz Bizon <grzesiek.bizon@gmail.com>2016-05-30 13:53:25 +0200
commita55e8f109fbaec1bb2db19a37a6537d8833c995c (patch)
tree12fbb211730776614c224dbf6f14aec11fc3a3f1 /app/services/git_tag_push_service.rb
parent43c35b0f20fb3bb67ea2b96bf8f806c7e95b6aec (diff)
downloadgitlab-ce-a55e8f109fbaec1bb2db19a37a6537d8833c995c.tar.gz
Enable Style/NegatedIf Rubocop coprubocop/enable-negatedif-style-cop
Favor `unless` over `if` for negative conditions (or control flow ||). See #17478
Diffstat (limited to 'app/services/git_tag_push_service.rb')
-rw-r--r--app/services/git_tag_push_service.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/app/services/git_tag_push_service.rb b/app/services/git_tag_push_service.rb
index 7410442609d..299a0a967b0 100644
--- a/app/services/git_tag_push_service.rb
+++ b/app/services/git_tag_push_service.rb
@@ -23,7 +23,7 @@ class GitTagPushService < BaseService
commits = []
message = nil
- if !Gitlab::Git.blank_ref?(params[:newrev])
+ unless Gitlab::Git.blank_ref?(params[:newrev])
tag_name = Gitlab::Git.ref_name(params[:ref])
tag = project.repository.find_tag(tag_name)
if tag && tag.target == params[:newrev]