diff options
| author | Nick Thomas <nick@gitlab.com> | 2019-03-27 16:18:28 +0000 |
|---|---|---|
| committer | Nick Thomas <nick@gitlab.com> | 2019-03-28 16:18:23 +0000 |
| commit | f086dbf66ee54e684fed4be17bce1e3537779d24 (patch) | |
| tree | 2b095a22cba62bdc5c933d6b488572bca883e929 /app/services/issuable_base_service.rb | |
| parent | 013f7cd24c4359d5d704b719d85b6df7ca1fdd55 (diff) | |
| download | gitlab-ce-f086dbf66ee54e684fed4be17bce1e3537779d24.tar.gz | |
Add a thin encapsulation around .pluck(:id)
Diffstat (limited to 'app/services/issuable_base_service.rb')
| -rw-r--r-- | app/services/issuable_base_service.rb | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/app/services/issuable_base_service.rb b/app/services/issuable_base_service.rb index f35ad2a9d8b..2b2774746a2 100644 --- a/app/services/issuable_base_service.rb +++ b/app/services/issuable_base_service.rb @@ -76,13 +76,11 @@ class IssuableBaseService < BaseService find_or_create_label_ids end - # rubocop: disable CodeReuse/ActiveRecord def filter_labels_in_param(key) return if params[key].to_a.empty? - params[key] = available_labels.where(id: params[key]).pluck(:id) + params[key] = available_labels.id_in(params[key]).pluck_primary_key end - # rubocop: enable CodeReuse/ActiveRecord def find_or_create_label_ids labels = params.delete(:labels) |