diff options
| author | Adam Niedzielski <adamsunday@gmail.com> | 2016-12-01 09:45:06 +0100 |
|---|---|---|
| committer | Adam Niedzielski <adamsunday@gmail.com> | 2016-12-01 09:45:06 +0100 |
| commit | 1105597303496e60308f93441b591a6f7dfadc74 (patch) | |
| tree | f0a493646d0dedd15274223b9f0534a61f38c158 /app/services/issues/close_service.rb | |
| parent | 2adc6568a6f94b2844c95a0b699a0be9bb8980d1 (diff) | |
| download | gitlab-ce-1105597303496e60308f93441b591a6f7dfadc74.tar.gz | |
Refactor JiraService by moving code out of JiraService#execute methodclean-up-jira-service
The implicit interface of project services states that the "execute"
method is meant to be called when project hooks are executed.
Currently JiraService does not support any project events even though
JiraService#supported_events says that "commit" and "merge_request"
are supported. They are only used to render correct options in
JIRA configuration screen, but they are not supported.
Because of that, this commit makes "execute" method a no-op.
Diffstat (limited to 'app/services/issues/close_service.rb')
| -rw-r--r-- | app/services/issues/close_service.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/services/issues/close_service.rb b/app/services/issues/close_service.rb index ab4c51386a4..f1030912c68 100644 --- a/app/services/issues/close_service.rb +++ b/app/services/issues/close_service.rb @@ -17,7 +17,7 @@ module Issues # allowed to close the given issue. def close_issue(issue, commit: nil, notifications: true, system_note: true) if project.jira_tracker? && project.jira_service.active - project.jira_service.execute(commit, issue) + project.jira_service.close_issue(commit, issue) todo_service.close_issue(issue, current_user) return issue end |