summaryrefslogtreecommitdiff
path: root/app/services/members/destroy_service.rb
diff options
context:
space:
mode:
authorDouwe Maan <douwe@gitlab.com>2016-08-10 16:54:54 +0000
committerDouwe Maan <douwe@gitlab.com>2016-08-10 16:54:54 +0000
commitb1aac0382c406b3856db90e15df8b2a9ea7ff6cd (patch)
tree2db352e89f59c6ad5fb0dd7c89c40a001c590509 /app/services/members/destroy_service.rb
parent4ccba6bf2ddd48d66cd9cd8c6cee5eae19691cbb (diff)
parent2785a56e7d1968dfda03850a14af296d71b06503 (diff)
downloadgitlab-ce-b1aac0382c406b3856db90e15df8b2a9ea7ff6cd.tar.gz
Merge branch 'decouple-secret-keys' into 'master'
Store OTP secret key in secrets.yml ## What does this MR do? Migrate the value of `.secret` to `config/secrets.yml` if present, so that `.secret` can be rotated without preventing all users with 2FA from logging in. (On a clean setup, generate different keys for each.) ## Are there points in the code the reviewer needs to double check? I'm not sure we actually need `.secret` at all after this, but it seems safer not to touch it. ## Why was this MR needed? We have some DB encryption keys in `config/secrets.yml`, and one in `.secret`. They should all be in the same place. ## What are the relevant issue numbers? #3963, which isn't closed until I make the relevant changes in Omnibus too. ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - ~~API support added~~ - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5274
Diffstat (limited to 'app/services/members/destroy_service.rb')
0 files changed, 0 insertions, 0 deletions