diff options
author | Rémy Coutable <remy@rymai.me> | 2016-09-16 13:37:21 +0200 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2016-10-03 16:57:48 +0200 |
commit | e9d7b4f765605cfe25c2c4d8729e3d34cf5a979b (patch) | |
tree | cbd9dcd71f714bd9ea61ab299ab174631a7e4ba0 /app/services/members/destroy_service.rb | |
parent | c8b1311934935c7ac7fd901558e19ac496fbad2c (diff) | |
download | gitlab-ce-e9d7b4f765605cfe25c2c4d8729e3d34cf5a979b.tar.gz |
Invert method's naming
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'app/services/members/destroy_service.rb')
-rw-r--r-- | app/services/members/destroy_service.rb | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/app/services/members/destroy_service.rb b/app/services/members/destroy_service.rb index ee072065523..431da8372c9 100644 --- a/app/services/members/destroy_service.rb +++ b/app/services/members/destroy_service.rb @@ -17,7 +17,7 @@ module Members member = find_member!(scope) - raise Gitlab::Access::AccessDeniedError if cannot_destroy_member?(member) + raise Gitlab::Access::AccessDeniedError unless can_destroy_member?(member) AuthorizedDestroyService.new(member, current_user).execute end @@ -35,8 +35,8 @@ module Members end end - def cannot_destroy_member?(member) - !member || !can?(current_user, action_member_permission(:destroy, member), member) + def can_destroy_member?(member) + member && can?(current_user, action_member_permission(:destroy, member), member) end end end |