diff options
| author | Rémy Coutable <remy@rymai.me> | 2018-02-16 15:10:22 +0100 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2018-02-27 16:02:22 +0100 |
| commit | 1c88d92b3fe174a56080575a14d6b473f17f7d8f (patch) | |
| tree | 7150c48b368e82d70f6bfc228c3d836c7be7c3ac /app/services/members/update_service.rb | |
| parent | e82f629be4b9c91e2611095cd4296e487ed137ef (diff) | |
| download | gitlab-ce-1c88d92b3fe174a56080575a14d6b473f17f7d8f.tar.gz | |
Improve Member servicesrc/reduce-delta-with-ce-in-controllers-ce
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'app/services/members/update_service.rb')
| -rw-r--r-- | app/services/members/update_service.rb | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/app/services/members/update_service.rb b/app/services/members/update_service.rb index ebea9f96069..48b3d59f7bd 100644 --- a/app/services/members/update_service.rb +++ b/app/services/members/update_service.rb @@ -2,8 +2,7 @@ module Members class UpdateService < Members::BaseService # returns the updated member def execute(member, permission: :update) - permission_target = permission == :override ? source : member - raise Gitlab::Access::AccessDeniedError unless can?(current_user, action_member_permission(permission, member), permission_target) + raise Gitlab::Access::AccessDeniedError unless can?(current_user, action_member_permission(permission, member), member) old_access_level = member.human_access |