summaryrefslogtreecommitdiff
path: root/app/services/merge_requests/post_merge_service.rb
diff options
context:
space:
mode:
authorDouwe Maan <douwe@gitlab.com>2015-10-18 15:07:02 +0200
committerDouwe Maan <douwe@gitlab.com>2015-10-18 15:07:02 +0200
commitd12e49c5916a42dafba32555405878f32c7ad254 (patch)
treeafa027cf2808fb7e9cbe2ca490d0023a559e3b43 /app/services/merge_requests/post_merge_service.rb
parent41615ddde4d5ae70bef944d9b156b687af2ca532 (diff)
downloadgitlab-ce-d12e49c5916a42dafba32555405878f32c7ad254.tar.gz
Fix bug preventing mentioned issued from being closed when MR is merged using fast-forward merge.close-issues-by-mr
Diffstat (limited to 'app/services/merge_requests/post_merge_service.rb')
-rw-r--r--app/services/merge_requests/post_merge_service.rb10
1 files changed, 10 insertions, 0 deletions
diff --git a/app/services/merge_requests/post_merge_service.rb b/app/services/merge_requests/post_merge_service.rb
index aceb8cb9021..8f25c5e2496 100644
--- a/app/services/merge_requests/post_merge_service.rb
+++ b/app/services/merge_requests/post_merge_service.rb
@@ -6,6 +6,7 @@ module MergeRequests
#
class PostMergeService < MergeRequests::BaseService
def execute(merge_request)
+ close_issues(merge_request)
merge_request.mark_as_merged
create_merge_event(merge_request, current_user)
create_note(merge_request)
@@ -15,6 +16,15 @@ module MergeRequests
private
+ def close_issues(merge_request)
+ return unless merge_request.target_branch == project.default_branch
+
+ closed_issues = merge_request.closes_issues(current_user)
+ closed_issues.each do |issue|
+ Issues::CloseService.new(project, current_user, {}).execute(issue, merge_request)
+ end
+ end
+
def create_merge_event(merge_request, current_user)
EventCreateService.new.merge_mr(merge_request, current_user)
end