diff options
| author | Heinrich Lee Yu <hleeyu@gmail.com> | 2019-01-11 22:58:18 +0800 |
|---|---|---|
| committer | Heinrich Lee Yu <hleeyu@gmail.com> | 2019-01-12 00:05:36 +0800 |
| commit | 2f76ff19f8f520a584a1259bd0c779e988cd7360 (patch) | |
| tree | bd520f3064a21ece51da2418f2f3b67c2bacfc4f /app/services/milestones | |
| parent | 6b2f81f6078e96f081154c50dc25e54fe7c09d6f (diff) | |
| download | gitlab-ce-2f76ff19f8f520a584a1259bd0c779e988cd7360.tar.gz | |
Fix MilestonesFinder to pass relations to scope
Instead of querying relations into ids we just pass them to the model
scope because the scope supports it now.
Also changes other calls to `Milestone.for_projects_and_groups`
Diffstat (limited to 'app/services/milestones')
| -rw-r--r-- | app/services/milestones/promote_service.rb | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/app/services/milestones/promote_service.rb b/app/services/milestones/promote_service.rb index 39071b5dc14..cbe5996e8ca 100644 --- a/app/services/milestones/promote_service.rb +++ b/app/services/milestones/promote_service.rb @@ -82,11 +82,9 @@ module Milestones end # rubocop: enable CodeReuse/ActiveRecord - # rubocop: disable CodeReuse/ActiveRecord def group_project_ids - @group_project_ids ||= group.projects.pluck(:id) + group.projects.select(:id) end - # rubocop: enable CodeReuse/ActiveRecord def raise_error(message) raise PromoteMilestoneError, "Promotion failed - #{message}" |