summaryrefslogtreecommitdiff
path: root/app/services/notification_service.rb
diff options
context:
space:
mode:
authorLin Jen-Shin <godfat@godfat.org>2016-10-21 18:16:39 +0800
committerLin Jen-Shin <godfat@godfat.org>2016-10-21 18:18:03 +0800
commit6061c9fa3d942c4b1aa466ee8f5f8eb3ae48853e (patch)
tree58420c8b0a2f5a6649c6aba516223942d4fc60c9 /app/services/notification_service.rb
parent1cdad622aacf9ae7e7d61e575aaa77dddf7ae7b9 (diff)
downloadgitlab-ce-6061c9fa3d942c4b1aa466ee8f5f8eb3ae48853e.tar.gz
Send only to users have :read_build access, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6342#note_17193335
Diffstat (limited to 'app/services/notification_service.rb')
-rw-r--r--app/services/notification_service.rb11
1 files changed, 8 insertions, 3 deletions
diff --git a/app/services/notification_service.rb b/app/services/notification_service.rb
index 2cc9a9fd7bf..f48255b2e6c 100644
--- a/app/services/notification_service.rb
+++ b/app/services/notification_service.rb
@@ -489,9 +489,14 @@ class NotificationService
end
def reject_users_without_access(recipients, target)
- return recipients unless target.is_a?(Issuable)
-
- ability = :"read_#{target.to_ability_name}"
+ ability = case target
+ when Issuable
+ :"read_#{target.to_ability_name}"
+ when Ci::Pipeline
+ :read_build # We have build trace in pipeline emails
+ end
+
+ return recipients unless ability
recipients.select do |user|
user.can?(ability, target)