Add latest changes from gitlab-org/gitlab@master

1 files changed, 22 insertions, 1 deletions

diff --git a/app/services/projects/create_from_template_service.rb b/app/services/projects/create_from_template_service.rb
index 31977a7c76a..91ece024e13 100644
--- a/app/services/projects/create_from_template_service.rb
+++ b/app/services/projects/create_from_template_service.rb
@@ -9,7 +9,9 @@ module Projects
     end
 
     def execute
-      file = Gitlab::ProjectTemplate.find(template_name)&.file
+      return project unless validate_template!
+
+      file = built_in_template&.file
 
       override_params = params.dup
       params[:file] = file
@@ -24,6 +26,25 @@ module Projects
         params.delete(:template_name).presence
       end
     end
+
+    private
+
+    def validate_template!
+      return true if built_in_template
+
+      project.errors.add(:template_name, _("'%{template_name}' is unknown or invalid" % { template_name: template_name }))
+      false
+    end
+
+    def built_in_template
+      strong_memoize(:built_in_template) do
+        Gitlab::ProjectTemplate.find(template_name)
+      end
+    end
+
+    def project
+      @project ||= ::Project.new(namespace_id: params[:namespace_id])
+    end
   end
 end