summaryrefslogtreecommitdiff
path: root/app/services/system_note_service.rb
diff options
context:
space:
mode:
authorZeger-Jan van de Weg <zegerjan@gitlab.com>2016-03-18 19:34:04 +0100
committerZeger-Jan van de Weg <zegerjan@gitlab.com>2016-03-18 19:34:04 +0100
commit70ca3370ebc840ce8272c78bd7ff7f5ea0c957b1 (patch)
tree42b2a99520c33584a1cbfde4d239d69c5b23028b /app/services/system_note_service.rb
parenteba00325520a08939f3cb4b5a71c8beb8b457266 (diff)
downloadgitlab-ce-70ca3370ebc840ce8272c78bd7ff7f5ea0c957b1.tar.gz
\#to_branch_name now uses the iid as postfixissue-branch-iid-postfix
Given the branch name 'mep-mep' with an iid being 1, the current way, master's way, would yield a branch name of 1-mep-mep. The problem for larger projects however would be that a developer might forget what iid the issue was. When this developer would try to tab complete it would: - Or result in 20+ branches possibly - Or start with the wrong digit, try again with digit++ - Would see 20 branches, repeat Thus the obvious way of solving this is letting the dev tab complete on the issue title, which is easier to remember.
Diffstat (limited to 'app/services/system_note_service.rb')
-rw-r--r--app/services/system_note_service.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/app/services/system_note_service.rb b/app/services/system_note_service.rb
index f09b77c4a57..2afcaad4646 100644
--- a/app/services/system_note_service.rb
+++ b/app/services/system_note_service.rb
@@ -210,7 +210,7 @@ class SystemNoteService
# Called when a branch is created from the 'new branch' button on a issue
# Example note text:
#
- # "Started branch `201-issue-branch-button`"
+ # "Started branch `issue-branch-button-201`"
def self.new_issue_branch(issue, project, author, branch)
h = Gitlab::Application.routes.url_helpers
link = h.namespace_project_compare_url(project.namespace, project, from: project.default_branch, to: branch)