diff options
| author | Timothy Andrew <mail@timothyandrew.net> | 2016-09-21 00:47:37 +0530 |
|---|---|---|
| committer | Timothy Andrew <mail@timothyandrew.net> | 2016-09-21 00:47:37 +0530 |
| commit | 918e589c2b29c18d9fe3a8e6c93a3f490c86beb1 (patch) | |
| tree | 4b354c178952b4369beb16af43c6b75f9d882c49 /app/services | |
| parent | a4a0ce95001b93c2ed65a18946542f3eecdf564e (diff) | |
| download | gitlab-ce-918e589c2b29c18d9fe3a8e6c93a3f490c86beb1.tar.gz | |
Implement a second round of review comments from @DouweM.
- Don't use `TableReferences` - using `.arel_table` is shorter!
- Move some database-related code to `Gitlab::Database`
- Remove the `MergeRequest#issues_closed` and
`Issue#closed_by_merge_requests` associations. They were either
shadowing or were too similar to existing methods. They are not being
used anywhere, so it's better to remove them to reduce confusion.
- Use Rails 3-style validations
- Index for `MergeRequest::Metrics#first_deployed_to_production_at`
- Only include `CycleAnalyticsHelpers::TestGeneration` for specs that
need it.
- Other minor refactorings.
Diffstat (limited to 'app/services')
| -rw-r--r-- | app/services/create_deployment_service.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/services/create_deployment_service.rb b/app/services/create_deployment_service.rb index e958e91d612..799ad3e1bd0 100644 --- a/app/services/create_deployment_service.rb +++ b/app/services/create_deployment_service.rb @@ -13,7 +13,7 @@ class CreateDeploymentService < BaseService deployable: deployable ) - deployment.update_merge_request_metrics + deployment.update_merge_request_metrics! deployment end |