diff options
| author | Douwe Maan <douwe@gitlab.com> | 2016-11-28 03:34:12 +0000 |
|---|---|---|
| committer | Douwe Maan <douwe@gitlab.com> | 2016-11-28 03:34:12 +0000 |
| commit | d8f75233686fe20bff26599704fbcb235f7bb43b (patch) | |
| tree | 15a38c9b174b279bac9f917c991e29b0967b9622 /app/services | |
| parent | eff2404785f58241f947bd7388564f49119d517d (diff) | |
| parent | 0ba03d7eb1d80e019b9b8266f0e14356d32e7d69 (diff) | |
| download | gitlab-ce-d8f75233686fe20bff26599704fbcb235f7bb43b.tar.gz | |
Merge branch 'events-cache-invalidation' into 'master'
Remove caching of events data
This MR removes the caching of events data as this was deemed unnecessary while increasing load on the database. See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6578#note_18864037 and 5371da341e9d7768ebab8e159b3e2cc8fad1d827 for more information.
See merge request !6578
Diffstat (limited to 'app/services')
| -rw-r--r-- | app/services/issuable_base_service.rb | 2 | ||||
| -rw-r--r-- | app/services/notes/delete_service.rb | 1 | ||||
| -rw-r--r-- | app/services/notes/update_service.rb | 1 | ||||
| -rw-r--r-- | app/services/projects/transfer_service.rb | 3 |
4 files changed, 0 insertions, 7 deletions
diff --git a/app/services/issuable_base_service.rb b/app/services/issuable_base_service.rb index 575795788de..d698b295e6d 100644 --- a/app/services/issuable_base_service.rb +++ b/app/services/issuable_base_service.rb @@ -184,8 +184,6 @@ class IssuableBaseService < BaseService params[:label_ids] = process_label_ids(params, existing_label_ids: issuable.label_ids) if params.present? && update_issuable(issuable, params) - issuable.reset_events_cache - # We do not touch as it will affect a update on updated_at field ActiveRecord::Base.no_touching do handle_common_system_notes(issuable, old_labels: old_labels) diff --git a/app/services/notes/delete_service.rb b/app/services/notes/delete_service.rb index 7f1b30ec84e..a673e8e9dde 100644 --- a/app/services/notes/delete_service.rb +++ b/app/services/notes/delete_service.rb @@ -2,7 +2,6 @@ module Notes class DeleteService < BaseService def execute(note) note.destroy - note.reset_events_cache end end end diff --git a/app/services/notes/update_service.rb b/app/services/notes/update_service.rb index 1361b1e0300..75a4b3ed826 100644 --- a/app/services/notes/update_service.rb +++ b/app/services/notes/update_service.rb @@ -5,7 +5,6 @@ module Notes note.update_attributes(params.merge(updated_by: current_user)) note.create_new_cross_references!(current_user) - note.reset_events_cache if note.previous_changes.include?('note') TodoService.new.update_note(note, current_user) diff --git a/app/services/projects/transfer_service.rb b/app/services/projects/transfer_service.rb index 28470f59807..34ec575e808 100644 --- a/app/services/projects/transfer_service.rb +++ b/app/services/projects/transfer_service.rb @@ -61,9 +61,6 @@ module Projects # Move missing group labels to project Labels::TransferService.new(current_user, old_group, project).execute - # clear project cached events - project.reset_events_cache - # Move uploads Gitlab::UploadsTransfer.new.move_project(project.path, old_namespace.path, new_namespace.path) |